MrPowers/chispa

Add allow_nan_equality option to assert_approx_df_equality

mitches-got-glitches opened this issue · 3 comments

I feel like this would be quite useful. Were there any design choices for why it wasn't included or would this be a useful addition?

def assert_approx_df_equality(df1, df2, precision, ignore_nullable=False):
assert_schema_equality(df1.schema, df2.schema, ignore_nullable)
assert_generic_rows_equality(df1, df2, are_rows_approx_equal, [precision])

@mitches-got-glitches - yea, allow_nan_equality is probably even more important for assert_approx_df_equality. Feel up for sending me a PR?

Hi @MrPowers , yes I will have a go this week! Cheers

Awesome, thanks @mitches-got-glitches!