Add allow_nan_equality option to assert_approx_df_equality
mitches-got-glitches opened this issue · 3 comments
mitches-got-glitches commented
I feel like this would be quite useful. Were there any design choices for why it wasn't included or would this be a useful addition?
chispa/chispa/dataframe_comparer.py
Lines 38 to 40 in 500793e
MrPowers commented
@mitches-got-glitches - yea, allow_nan_equality
is probably even more important for assert_approx_df_equality
. Feel up for sending me a PR?
mitches-got-glitches commented
Hi @MrPowers , yes I will have a go this week! Cheers
MrPowers commented
Awesome, thanks @mitches-got-glitches!