Add unit tests for constraint_append not null constraints

Question

Add unit tests for constraint_append not null constraints

Opened this issue a year ago · 5 comments

MrPowers commented a year ago

Make sure the constraint_append function works well for NOT NULL constraints in the test suite.

See this blog post for more on NOT NULL constraints: https://delta.io/blog/2022-11-21-delta-lake-contraints-check/

Answer 1 · 2023-03-12T07:03:31.000Z

I'd be happy to add these tests, can you assign it to me please?

Answer 2 · 2023-03-12T07:06:42.000Z

@cs23andris Great, assigned you!

Answer 3 · 2023-03-18T05:54:29.000Z

Unfortunately, NOT NULL constraints are not checked in the current implementation of the constraint_append function, because they're not stored as delta table properties but with the table schema. I think it'd be nice to extend the constraint_append to check for the nullability of columns as well. Can I proceed with that in this issue?

Answer 4 · 2023-03-18T12:04:13.000Z

Sounds good and thank you @cs23andris, feel free to work on this! :)

Answer 5 · 2023-03-18T12:45:42.000Z

Awesome, glad we have unit tests to check the edge cases. Thanks for working on this one @cs23andris.