Flake8 does not fail

Question

Flake8 does not fail

Closed this issue 2 years ago · 3 comments

This commit broke some Flake rules, but the Action did not fail, but IMO it should fail. WDYT?

Answer 1 · 2022-12-29T21:02:29.000Z

@robertkossendey I can make it fail do you want it to fail? I thought we only want the flake8 checks to be recorded in verbose without the flake pipeline actually failing

Answer 2 · 2022-12-29T21:06:33.000Z

@souvik-databricks I think you are referring to our black config, there it should not format but only fail. Would be great if you could make flake8 fail :) also we should align the max-code-length in our pyproject with the one in the GitHub Workflow.

Answer 3 · 2022-12-29T21:51:33.000Z

@souvik-databricks I see that black also does not fail. We should definitely make it fail, but not reformat :)