Small function name error in README docs

Question

Small function name error in README docs

Closed this issue a year ago · 4 comments

It seems to me the referenced function name in the README docs at https://github.com/MrPowers/mack#drop-duplicates should be mack.drop_duplicates(delta_table=deltaTable, duplication_columns=["col1"]) but it actually is mack.drop_duplicates_pkey(delta_table=deltaTable, duplication_columns=["col1"]).

Answer 1 · 2023-01-19T15:27:19.000Z

@Triamus - thanks for reporting this. Would you be willing to submit a pull request to fix this? We'd love to have you as a contributor!

Answer 2 · 2023-01-19T15:32:54.000Z

@MrPowers Ya, I was actually thinking about it but I wasn't sure if I have to run the whole test suite locally which would be difficult on the system I'm currently on. Can I do the PR without that? Thanks.

Answer 3 · 2023-01-19T17:21:47.000Z

@Triamus - yea, you don't need to worry about running the test suite. Just a PR is fine. Let me know if you need any help!

Answer 4 · 2023-01-22T21:01:38.000Z

Thanks, I'll try a PR then.