If it shown "You can share this tab" the height doesn't change
Sav22999 opened this issue · 9 comments
The row should be set at "1" (or 2)
In addition, I think it's better say "You can share this link" (instead of "tab")
I disagree.
For one, #137 will reduce the height (since it switches to a min-height in CSS).
Second, the Web Extension is using the currently open tab for sharing. A „link” could be a highlighted piece of content (or an option for the context menu), which isn't part of this extension (to my knowledge).
But "tab" mean you cannot share other website/link in that specific tab
Which is the actual behaviour as far as I know.
@Mte90 Halp!
I don't get what Sav is asking for here :-(
@Ryuno-Ki No, the behaviour you want to is to avoid the URL "about:" etc. not the entire tab. The tab remains the same if you go, after, to "facebook.com", for example, but then you can share that specific URL/link.
I don't know how I can explain it in other ways, actually.
As I understood is mainly a wording issues, as we are not sharing the tab but the link of the tab.
What term is better understood by users?
I mean, okay, you can navigate within one tab to another URL.
But even then, you're sharing the link of the current tab.
Either way, I leave the decision to you, @Mte90.
@Ryuno-Ki in fact "[...] this link", you need to specify that the link you can't share is "this" (so of this tab, it is implicit)
I am to change the wording with link.
Anyway the latest pr fix the height we need just a fix to the wording that I will do now, so I can release a new version.