Mudlet/Mudlet

PTB updater loops the same version

Kebap opened this issue · 3 comments

Kebap commented

Brief summary of issue / Description of requested feature:

Mudlet suggests to install a new PTB version, but it's actually the same that was one already installed

Steps to reproduce the issue / Reasons for adding feature:

  1. Install PTB 2024-02-19 from Mudlet website
  2. Check for upgrades and install and restart
    grafik
  3. After restart, PTB changelog popup is shown but empty
    grafik
  4. PTB version is still PTB 2024-02-19

Error output / Expected result of feature

  1. PTB changelog should display changes
  2. PTB version should be newer after install

Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:

Problem seems to stem from the sha1 being duplicated in one place, and not the other.

Noted on Win11

For comparison, see a few rounds of the loop happening here:

UpdateLoop

SlySven commented

Sadly, this is very probably another aspect of exactly the same thing that causes #7158, as you observe, due to some weirdness in how the version information is getting a Git SHA1 from two sources when run through the CI/CB process - but not for local, developer machine builds. Do we have any information as to whether this is a Windows OS specific issue or is shared across all three platforms that have updater support?

SlySven commented

Ah, I have just determined that the doubled SHA1 also happens on GNU/Linux PTBs:
image

On the bright side - it does look like the correct Icon is being used now (yeah - that is clutching at straws...)

Kebap commented

Confirmed fixed in PTB 2024-02-28-23c8a37f