Fix peerDependencies for Angular 7

Question

Fix peerDependencies for Angular 7

glmanhtu opened this issue 6 years ago · 2 comments

Hello!
Do you have plans for angular 7 support?
When I install ngx-disqus on angular 7 app I've got this issues:

npm WARN ngx-disqus@2.4.0 requires a peer of @angular/common@^5.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-disqus@2.4.0 requires a peer of @angular/core@^5.0.0 but none is installed. You must install peer dependencies yourself.
Greetings,

Answer 1 · 2018-10-25T23:23:07.000Z

This is not an issue, it is just a peerDependencies warning, it works on Angular 7

Answer 2 · 2018-10-26T09:24:23.000Z

Yeah, it works, but could you update the plugin to remove those warning ?
Thank a lot,