Fix lunch period of default block schedule when Portal feed unavailable
Opened this issue · 1 comments
When the portal feed is unavailable, we fall back to using the generic block schedule, and substitute any custom classes the user has inserted in their Settings page. Because classes also have a "type" field, we are able to determine if a user has first lunch or second; however, the current algorithm does not reflect this and instead shows one bug lunch that takes up both lunch slots, and completely ignores the the class that goes before/after.
We should have the algorithm use the specified block type to determine if the user as first or second lunch. If no classes are specified and the type is unknown, default to saying "Block X + Lunch"
Apparently Portal is working on this issue, so this is slightly less urgent as a fix should probably be released next Wednesday. Fixed portal feeds means we don't have to fall back to this method.