Bug: method "insertIn" doesn't care if we drop node into another node which is in leaves array in config

Question

Bug: method "insertIn" doesn't care if we drop node into another node which is in leaves array in config

olsoncarsen opened this issue 3 years ago · 8 comments

If we want to use drag and drop while async loading and there are some nodes without children, we put their ids into the leaves array in config. If we drag and drop into the node which is in leaves array, icon will not show and node id won't be removed from leaves array.
Way to reproduce: drag node into the "text3" or "text4".
Sandbox: https://codesandbox.io/s/async-forked-qq3mii?file=/src/App.vue

Answer 1 · 2022-04-07T18:45:31.000Z

olsoncarsen commented 3 years ago

Answer 2 · 2022-04-27T09:26:30.000Z

Hello, i'm sorry i'm very busy right now, I will take a look as soon as I can.

Answer 3 · 2022-04-27T11:09:59.000Z

It's alright

Answer 4 · 2022-07-23T07:23:06.000Z

Hey I wanted to have a look but I feel that your example is not working anymore can you create a new test case please :) ?

Answer 5 · 2022-07-25T18:23:38.000Z

https://codesandbox.io/s/async-forked-qq3mii?file=/src/App.vue

Answer 6 · 2022-07-25T18:25:32.000Z

@N00ts this should work, steps to reproduce: drag task3 into task4

Answer 7 · 2022-08-15T15:24:37.000Z

Hello, what you try to do is to handle "leaves" manually. The icon does not appear because you keep the id the drop target node in config.leaves. I modifed the project and put "node-drop" after insert event so you can handle it manually in this event.

Regards

Answer 8 · 2022-08-23T09:11:23.000Z

@N00ts, okay. I'm closing this issue