NASA-LIS/LISF

SMOS NRT DA, issue in grid finding period

Closed this issue · 1 comments

Bug Description

Yonghwan Kwon previously reported SMOS data are missing in large areas over the north-western CONUS where most ISMN stations are located. This issue was attributed to the hard-coded “grid finding period” in LDT. The “grid finding period” was originally (and tentatively) set to 30 days, but it seems that this period was not enough to assign all SMOS grids to the LIS grids. Yonghwan Kwon tested longer periods and the results are shown in the link below:

https://nasa-my.sharepoint.com/:p:/g/personal/svkumar_ndc_nasa_gov/Ec-jgSEoQbBDpMdrW3Xrc0gBm_-1R9H_EVq1Jy3hXl1NTA?e=qXgje0

When the 150-day period was used for “grid finding” in LDT, the SMOS data (unscaled; before model-based QC) could cover the whole CONUS domain.

Screen Shot 2023-04-03 at 11 50 46 AM

Steps to Replicate

I do not have a test case for this issue. I can create a test case if needed. But, he confirmed that he did not fix the bug in the code prior to his departure.

See the following email exchange
Hi Mahdi,
Yes. You are right.
Thanks,
Yonghwan

From: "Navari, Mahdi (GSFC-617.0)[UNIV OF MARYLAND COLLEGE PARK]" <mahdi.navari@nasa.gov>
Date: Friday, March 24, 2023 at 12:20 PM
To: LIS-557WW <LIS-557WW@nasa.onmicrosoft.com>, Yonghwan Kwon <yhkwon@umd.edu>
Subject: Re: [update] SMOS DA

Hi Yonghwan,
We were discussing the SMOS NRT DA and I just remembered an old conversation between us (see previous emails below).
Do we need to change the “grid finding period” from 30 days to 150 days?

https://github.com/NASA-LIS/LISF/blob/48a8c51aa15c49031be45342ed8b441cc27e18c0/ldt/DAobs/SMOS_NRTNN_L2sm/readSMOSNRTNNL2smObs.F90#L281

If that is the case, is this the right and only places we need to change?

Thanks
Mahdi

Resolved by #1302