Resolve remote testing on PRs

Question

Resolve remote testing on PRs

mkelley opened this issue 2 years ago · 2 comments

As noted in #345 , we cannot use the NASA ADS API without publicly exposing a secret API key. These tests could be restored if the ads-based tests could be skipped (perhaps using a pytest.mark or a test that the key exists), or if the ads module was used in sandbox mode. Or may be use a combination of the two?

Answer 1 · 2022-07-23T02:48:31.000Z

I thought you used the GitHub repository secret to save the ADS key and allow for tests using secret keys. Perhaps I missed something?

Answer 2 · 2022-07-24T11:46:20.000Z

Sorry, I mean for this to be specific to pull requests. We can indeed use the API key with our weekly tests.