NCATS-Gamma/robokop

High-level schema of ROBOKOP KG

karafecho opened this issue · 4 comments

Is this schema accurate (from a soon-to-be-published manuscript)?

image

I'm wondering if 'genetic variant' is incorrect and should be replaced by 'genetic condition'. I'm also questioning the connections between nodes.

"Genetic variant" should be replaced by "sequence variant" (e.g. snps). "genetic condition" has been removed b/c it's not a valid biolink term. (I think genetic condition is now a boolean property on diseases).

Otherwise, it all looks correct to me. Is there some other specific thing that looks weird to you?

I see. The UI is confusing because you can select 'genetic condition' as a node, but you won't have any answers returned. I was expecting 'genetic variant', but didn't see that option and didn't think of searching for 'sequence variant', so the schema node seemed questionable to me.

Regarding the edges, I just wanted to verify that they were correct, so thanks.

I think I have an editable version of the schema; if not, I'll ask Kelsey to update the schema. In terms of the publication, I'll swap out schemas during the proofing stage. However, I also think we should make the schema accessible from the UI. Of course, we'll need to update it from time to time, but I think users will find it helpful.

Updated schema:
Figure1_revised2

Looks good, thanks.