NCC-CNC/wheretowork

add indication to the user that solution setting was updated

Closed this issue · 10 comments

currently, toggles and sliders update without letting the user know #285

big yaml files take a longer time to load in on the server cause a delay in the icon colour ...

If a yaml file has been loaded one needs to clear it by clicking 'cancel' in the Choose File pop up. It would be great if this step would not be necessary.

What do you think about displaying some meta data after the yaml file has been uploaded?
Something like author name and date. Maybe something else too, but I'm not sure.

Should toggling off Update solution settings remove the yaml and turn the icon grey?

Tooltip stays up/active after file is uploaded.
It disappears on other items.

If a yaml file has been loaded one needs to clear it by clicking 'cancel' in the Choose File pop up. It would be great if this step would not be necessary.

That's a good point. Cancel clears the file, however with the current set up the user can update the .yaml without clearing it. Instead it just updates it. I think this is how the import modals work as well on the welcome page.

What do you think about displaying some meta data after the yaml file has been uploaded? Something like author name and date. Maybe something else too, but I'm not sure.

I like this idea. At minimum I could add that info to the tooltip on the green file icon? Or we could think of a spot on the UI to add that info

Should toggling off Update solution settings remove the yaml and turn the icon grey?

I am not sure ... the toggle for this only just hides/shows the setting. It doesn't modify behavior like the other settings do. The tricky thing is if the user toggles off the setting, what should happen to all the new solution values? Reset to the original? Do nothing? The low code option would be to just always have the toggle on where the user can not turn it off, or remove the toggle entirely, or just change the tooltip on the toggle to say hide/show instead of enable/disable?

Tooltip stays up/active after file is uploaded. It disappears on other items.

I updated the code so the behavior is better by updating the file icon colors on the server once the data is passed to R. There are 3 states to the file icon: grey == no file, green == success and red == unsuccessful. I also had to add: set the priority: "event"

Shiny.setInputValue(manager, {
id: id,
setting: "fileinput",
value: filecontent,
type: "parameter"
}, {priority: "event"});

https://shiny.rstudio.com/articles/communicating-with-js.html

This should be working better now., but I think could still be improved on

Will close this for now. Any new edits to this will be on a new issue/PR