adjust for update to apex

Question

Closed this issue 9 years ago · 3 comments

The apex package is going to update soon (See: thibautjombart/apex#46). With this update comes a change to the accessor locusNames(). It has now been changed to getLocusNames() and setLocusNames(). This will have to change in these two lines: https://github.com/NESCent/popgenInfo/blame/cb0d66460c062ff8e2990c185b7f737f69f54050/use/PopDiffSequenceData.Rmd#L50-L51

The pull request should only be initiated once apex is on CRAN and the Docker container is rebuilt

Answer 1 · 2016-04-01T20:29:47.000Z

Apex has been updated. As soon as the docker container is updated, we should create a pull request from the apex-update branch.

Answer 2 · 2016-04-02T01:04:56.000Z

I triggered a rebuild, succeeded. Submitted pull request, see #181. Triggered re-run of the CI test.

Answer 3 · 2016-05-04T13:20:21.000Z

I believe this is done.