NET-A-PORTER/scala-uri

Scala URI fails to parse url that has a query string containing parameters with no values

Closed this issue · 2 comments

gmalouf commented

Version 0.3.4

This is a valid uri but does not parse under scala uri:

http://localhost:8080/ping?oi=TscV16GUGtlU&ppc=&bpc=

I have this happen since a partner of ours replaces macro values ${MY_VALUE} with an empty string if the value is not available.

theon commented

Hi Gary, Thanks for the bug report.

The parser has recently be completely rewritten (issue #13) and the bug you mentioned was fixed in the rewrite. This was only on master, so to save you having to rely on the latest SNAPSHOT I've promoted a new version 0.3.5. Could you try upgrading to 0.3.5, give us a shout if it doesn't solve the problem and I can reopen the ticket.

I've just added a unit test for this here with this commit to ensure it doesn't break in the future e217e45

Thanks again!

gmalouf commented

That worked for me - thanks for the quick turnaround.