NET-A-PORTER/scala-uri

Support Iterable[(String, String)] in ? operator

Opened this issue · 2 comments

Why not also allow ? and & accept an Iterable of pairs? That would be more in fitting with the dsl than addParams.

theon commented

Makes sense. I can add a overloaded version of ? and &.

theon commented

I need to revisit this. I think I need to audit all the parameter and return types and make sure they are sensible.

There was a recent twitter conversation about this where the consensus for return types was that they should be as specific as possible. There were mixed views on parameters types.