NETWAYS/go-check

Misleading name of metric

Closed this issue · 4 comments

Due to the fact, that #44 only supports IEC units and not all Uoms, the name of the package is not correct and misleading.

My recommendation for the "new" package name would be IECmetrics.

Any other opinions?

It depends: If you want to cover a broader spectrum of different measurement units, I would totally go for metrics (or maybe units or something like that and not even make a distinction between IEC and SI (or create subpackages for that).
If you want to focus solely on Bytes, if might be more intuitive to use something like metrics/bytes or units/bytes.

In any case, it might be worth thinking about how this relates to the convert part of this library.

@RincewindsHat as discussed, maybe evaluate if this can be changed in v0.5.0

Fixed by removing the code for now #91