Idea: Remove go-ps dependency
Closed this issue · 2 comments
martialblog commented
Right now we are importing go-ps
for just one reason, finding out if we run in the delve debugger.
if parent, err := ps.FindProcess(ppid); err == nil {
if parent.Executable() == "dlv" {
I do like to minimize dependencies as much as possible. Do we want to remove that piece of code or comment it out?
If I really really need to run delve, I can still enable it for debugging only. No need to ask the users to import it as a dependency
martialblog commented
@pdorschner @RincewindsHat What do you think?
pdorschner commented
I completely agree. It's only needed for a single case, and importing an entire package for that purpose doesn't make sense.