NFM-Studios/project-olly

Team Invites functionality isn't organized

mikemaddem opened this issue · 6 comments

mikemaddem commented

TeamInvite objects are stored and used to track membership on a team, however it'd be much easier to just check the user exists in the teams founder fk field, captains mtm field, or the players mtm field.

Seeing as this is a rather large fix porting a site from the previous work arounds could cause issues, would like this completed sooner rather then later to avoid compatability issues.

mikemaddem commented

For now we could look into more advanced filtering.

Here are some issues that I've noticed.

On the teaminvites page it shows invites for teams that you've created.

If a user has already declined an invite to a team a new invite can't be made.

mikemaddem commented

  • Match report permissions check needs to be updated

  • team invite create permissions need to be updated

  • team promotion permissions need to be updated

  • team remove player permissions need to be updated

  • tournament join permissions need to be updated.

  • TeamInviteGetForm.

  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

mikemaddem commented
  • Match report permissions check needs to be updated - NEEDS TESTING
  • team invite create permissions need to be updated - NEEDS TESTING
  • team promotion permissions need to be updated
  • team remove player permissions need to be updated -NEEDS TESTING
  • tournament join permissions need to be updated.
  • TeamInviteGetForm.
  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

  • [x]team leave updated - NEEDS TESTING
  • dissolve team updated - NEEDS TESTING
  • match list - needs updating
mikemaddem commented
  • Match report permissions check needs to be updated - NEEDS TESTING
  • team invite create permissions need to be updated - NEEDS TESTING
  • team promotion permissions need to be updated - unknown?
  • team remove player permissions need to be updated -NEEDS TESTING
  • tournament join permissions need to be updated.
  • TeamInviteGetForm.
  • Remove the through field of the mtm field of team.players - same for captain mtm field.

Other usages

  • [x]team leave updated - NEEDS TESTING
  • dissolve team updated - NEEDS TESTING
  • match list - NEEDS TESTING
  • Teams list
  • edit team permissions - needs testing
mikemaddem commented

keeping this open because tournament join and team permission need to be relooked at

mikemaddem commented

Reworked a lot of team membership functionality.
TODO:
Team dissolve
remove player
leave team

do not reflect the changes in userprofile.captain_teams or userprofile.founder_teams or userprofile.player_teams