No validation if the message is not of NHS 111 type.
Closed this issue · 6 comments
Description
When changing the document type of non-NHS 111 types of reports, the response is still successful, and the document appears in the queue.
Component
NHS111 adapter
Version
0.1.0
Step to Reproduce
- Put the valid a CDA in the payload
- Change :
ClinicalDocument->npfitlc:messageType@extension to something else,
Test Data
Any data
Preconditions
None
Environment
local environment
Severity
Low,
Priority
Not urgent
Expected Behavior
It should be a SOAP Fault ((as a consequence of sync mode of the adapter) with error description and/or diagnostic text:
'Message Type not supported here'
with error Code 430, and OID = 2.16.840.1.113883.2.1.3.2.4.17.227
(see NPFIT-FNT-TO-TAR-0083 02 CDA Interoperability - Point to Point Error Codes v1.0.pdf in the ITK CDA functionality pack)
Please retest this in the next 111 image release. Status is DEFERRED
@Kusnaditjung see before attached requirements and test cases document in issue
#115.
Validation of this particular element is easy to add yet not required by “TK2.2-Supplier Certified Requirements Coverage v8.5-NHS111Receiver.xls”.
cannot seem to find the documen mentioned ?
See comments here:
#115 (comment)
oh, you mean content validation ?? though the content validation can be ignored, for now, this particular element bear significant importance, this element specifies what templated message this message should conform to (in our case it should conform to NHS 111 message). In my understanding, this is the only element in the ClinicalDocument that says this is NHS 111 message (e.g not discharge, or other) and what messageType it must conform to, so if the value changes (e.g to discharge message type) the validation also need to change. I don't think the comment on #115 applies to this in that sense as there is more to it.
Only expect 111 accredited system supplier to send cda documents that are of type nhs 111