Scaling with Zoom-Factor no longer works (QGIS since 3.22?)

Question

Scaling with Zoom-Factor no longer works (QGIS since 3.22?)

Opened this issue 3 years ago · 15 comments

Not sure exactly since which version, but with 3.22 and 3.24 the scaling of a raster map with a Zoom-Factor =! 1.0 no longer works.

Solution: Comment out line 345 in GarminCustomMap.py

This line:
345: mapSettings.setOutputDpi(target_dpi)

is not needed and makes the map not being scaled (with all but the original canvas being white).

Answer 1 · 2022-08-30T14:02:43.000Z

Hy,

I have same issue with scaling, the raster appears not scaled in the bottom left of the kmz

Answer 2 · 2022-08-30T17:38:54.000Z

No i can't upgrading my QGIS version because for the moment QGIS 3.22 is the official version of my company.

Answer 3 · 2022-08-30T17:51:01.000Z

Hmmm, I can't test this because in the latest plugin version 3.4.1 and QGIS 3.26 zoom-factor is working. I get correctly scaled multi-jpg kmz files.

Try this fix suggested above by @chrismuller and please report back.

Open:
.local/share/QGIS/QGIS3/profiles/default/python/plugins/GarminCustomMap/GarminCustomMap.py

and comment the line
mapSettings.setOutputDpi(target_dpi)

by adding a # in front of the line to make it like this:
#mapSettings.setOutputDpi(target_dpi)

Answer 4 · 2022-08-30T18:10:58.000Z

Oh thanks ! It seems to be OK :)

Answer 5 · 2022-08-30T18:22:09.000Z

Good to know.

Closing the issue now.

Thanks @chrismuller!

Answer 6 · 2022-08-30T18:34:52.000Z

arf nope sorry, after some tests....when i got a vector on my raster i can see an offset between the raster and the vector :( and on google maps i can see that the raster is not well positionning...

Answer 7 · 2022-08-30T19:07:06.000Z

arf nope sorry, after some tests....when i got a vector on my raster i can see an offset between the raster and the vector :( and on google maps i can see that the raster is not well positionning...

Could you post a screenshot of what you are describing?

Answer 8 · 2022-08-31T10:28:01.000Z

Hy, The best place of the red zone near the river [image: image.png] The kmz: the red zone is not near the river [image: image.png] Thanks a lot for all that you made Véronique Le mar. 30 août 2022, à 16 h 07, esan0 ***@***.***> a écrit :

…

arf nope sorry, after some tests....when i got a vector on my raster i can see an offset between the raster and the vector :( and on google maps i can see that the raster is not well positionning... Could you post a screenshot of what you are describing? — Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADGYDS5HEWKNYFL6FXZUA3TV3ZLWJANCNFSM5PPL2LXA> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 9 · 2022-09-06T13:52:20.000Z

veroniqueC commented 2 years ago

Answer 10 · 2022-09-07T09:51:05.000Z

So after some tests, it' s came from my double screen ! With one screen all is ok and well positionning, with two screens, there is an offset...perhaps it's came from resolution?

Answer 11 · 2022-09-07T13:05:31.000Z

Thank you, VeroniqueC for all your testing! I think that you're right -- this issue is related to something other than the zoom-factor setting. I will keep this issue closed, but the double-monitor situation should be looked at as a bug. Could you open a separate issue and provide details in there, such as OS, versions of packages and QGIS, and the screenshots?

By the way, only the screenshot you posted recently is visible. The ones from August 31st are not showing up.

Thanks!

Answer 12 · 2022-11-21T21:50:01.000Z

Can you please reopen this issue. My suggested patch, i.e. commenting out the statement

            384: mapSettings.setOutputDpi(target_dpi)

which is now in line 384 of version 3.4.1, did not make into the committed version.

With this line still in, I still have the same issue that the zooming does not work for raster maps. I only get a large white canvas with the original raster map in the top left corner (i.e. the canvas is made bigger, but not the raster map itself). Whereas if I comment this line out, everything is working fine (also in 3.28.1).

Answer 13 · 2022-11-21T22:14:27.000Z

@esan0 Do you agree with the change in #29 ?

Answer 14 · 2022-11-21T22:27:19.000Z

Yes! Won't have access to my personal computer until tomorrow, but it looks good. I believe that I left this change out initially because in my testing it did not have an effect (Linux), and there didn't seem to be any comments about it in the PR. My apologies! Thanks! Egor On November 21, 2022 5:14:38 PM EST, Stefan Blumentrath ***@***.***> wrote: ***@***.*** Do you agree with the change in #29 ?

…

-- Reply to this email directly or view it on GitHub: #22 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

Answer 15 · 2022-11-21T23:04:37.000Z

FYI: I just uploaded a new version with the fix by @chrismuller Hope it gets approved soon, so it can be more widely tested...