Modern diag_manager:: diag_send_complete_instant has not been implemented
Opened this issue · 2 comments
Is your feature request related to a problem? Please describe.
Diag_send_complete_instant has not been implemented in the modern diag_manager, so it will do nothing and cause failures
FMS/diag_manager/diag_manager.F90
Lines 3868 to 3896 in 42f8506
Describe the solution you'd like
Diag_send_complete_instant needs to be implemented as it is used in SHiELD
https://github.com/NOAA-GFDL/atmos_drivers/blob/113a25fe6fea86bb5dce8fee064740b4b96237b9/SHiELD/atmos_model.F90#L738
Describe alternatives you've considered
N/A
Additional context
N/A
@laurenchilutti I think this is the cause of the full SHiELD test
FATAL from PE 17: atmos_4xdaily: diag_manager_mod: You skipped a time_step. Be sure that diag_send_complete is called at every time_step needed by the file.
fyi @bensonr
@uramirez8707 - do you think there is a way to set the variables in the diag_table[.yaml] to get around having to implement this function?