NOAA-GFDL/GFDL_atmos_cubed_sphere

remap_scalar_nggps_regional_bc overwrites Atm%ps for entire grid, not just boundary points

Closed this issue · 1 comments

Describe the bug

The remap_scalar_nggps_regional_bc overwrites Atm%ps for the entire grid, for each boundary. This results in gibberish pressure values, especially because most of psc and ps are -9999999. (See #215 for details on that.) Because of this, the RRFS crashes when run in debug mode.

      is=lbound(Atm%ps,1)                                                                                                                                                                                                                   
      ie=ubound(Atm%ps,1)                                                                                                                                                                                                                   
      js=lbound(Atm%ps,2)                                                                                                                                                                                                                   
      je=ubound(Atm%ps,2)                                                                                                                                                                                                                   
!                                                                                                                                                                                                                                            
      do j=js,je
      do i=is,ie
        Atm%ps(i,j)=ps(i,j)
      enddo
      enddo

To Reproduce
Read the code. Or, initialize ps_reg to real_snan, run it in debug mode, and examine the core dump using gdb.

Expected behavior
Only boundary regions are filled with boundary surface pressure.

Will open new issue shortly.