NOAA-GFDL/MOM6

Unicode characters in source?

Closed this issue · 2 comments

marshallward commented

Issue #244 inadvertently discovered three unicode hyphen characters:

  • src/parameterizations/lateral/MOM_load_love_numbers.F90 has a hyphen (U+2010)

  • src/tracer/boundary_impulse_tracer.F90 has two en dashes (U+2013).

There is not necessarily an issue with using them, but the makedep tool fails in some Python versions, and at the least needs to be resolved. We could also just replace them with the ASCII dash - (aka "hyphen-minus", U+002D).

adcroft commented

Wow - I bet that took some digging.

marshallward commented

Hopefully resolved here: #370

FWIW-
It seems even we were seeing this problem on our own end, including in our testing. But there was an oddity in the Makefile which would fix the problem if run a second time (possibly the config.status rule), so it was being ignored for some time.