CFCs do not work with rotated grids
Closed this issue · 1 comments
Although our physical MOM6 models do work with rotated grids (unless they use tripolar grid due to limitations with FMS), we are currently unable to use rotated grids with models that use certain tracer packages, including OCMIP2_CFCs. The specific problem is that in such cases, there is a call to allocate_surface_state() from the driver-level that includes an optional gas_fields_ocn argument that is then used to spawn the surface tracer fluxes. However, when we are using a rotated grid (ROTATE_INDEX = True), there is a second call to allocate_surface_state() for the rotated grid inside of extract_surface_state(), and this one is missing the gas_fields_ocn argument.
It should be possible to use sfc_state_in%tr_fields in place of gas_fields_ocn in this second call to allocate_surface_state() - it contains the same metadata, but because it is a coupler_2d_bc_type instead of a coupler_1d_bc_type, it would have to be a new optional argument to allocate_surface_state() and appropriate testing would be needed.
This issue was addressed by PR #638.