NOAA-GFDL/pace

Fail to init model on not implemented configurations

Opened this issue · 2 comments

The Pace repository does not carry all the capacity of the FV3 model. Therefore we need to strongly fail when the namelist/configuration required is not going to work or work poorly.

A first implementation is to use raise NotImplementedError in the __init__ function of the modules. DO NOT RAISE AT RUNTIME, keep guard at initialization or fear my wrath.

Current non-exhaustive list:

  • do_sat_adjust
  • kord is 9 or 10
  • nwat is 6
  • non hydrostatic

List to be double checked and completed

PR incoming with some checks

There are multiple microphysical schemes with the same number of water species, but the makeup of species is different. We need to come up with a better way than using nwat to determine how the water species break down for the liquid vs solid when computing the subgrid scale mixing.