NREL/nsrdb

pyhdf

MRossol opened this issue · 3 comments

MRossol commented

@mikebannis I can't seem to install pyhdf which will make pip installing NSRDB a pain. Any way we can remove pyhdf and instead access modis data by:

  1. converting from hdf4 to hdf5 using this tool:

    nsrdb/nsrdb/utilities/file_utils.py

    Line 167 in 930fcd0

    def convert_h4(path4, f_h4, path5, f_h5):
  2. access using h5py which is already a dependency?
mikebannis commented

That shouldn't be a problem. What's your desired timeline on the change?

MRossol commented

No rush, I think we will use the old code for 2020, so this can wait until end of the FY

grantbuster commented

pyhdf has been moved to a conditional import, only required if the nsrdb.albedo.modis module is being run:

nsrdb/nsrdb/albedo/modis.py

Line 75 in b2f01d3

import pyhdf