Albedo clean up
Closed this issue · 7 comments
@mikebannis, shitty ask, but we've updated our linters and it's failing on your albedo files, mind taking a look and cleaning up?
https://github.com/NREL/nsrdb/runs/2231772202?check_suite_focus=true
AFAICT the linter is running successfully:
2021-03-30 21:34:10 [NOTICE] All file(s) linted successfully with no errors detected
Where are you seeing the failure?
Whoops, forgot the linter only looks at "changed" files, here is the old one:
https://github.com/NREL/nsrdb/runs/2230183820?check_suite_focus=true
I see them now. Man, both eagle vim and pylint seem to really dislike f-strings. Looks like there are some arguments against using f-strings with logging, see pylint-dev/pylint#2395. Performance seems about nill for us, especially considering how IO bound the nsrdb code is. What's your take?
I honestly dont feel strongly about fstrings. I would be fine having them in our code bases. I think we're already not following best practices for logging strings as Dan had pointed out to us previously.
Fine by me, I'll add that to the pylint file to exclude.
okay push this to the branch, Mike I can't remember if there are any other pylint errors in albedo, but feel free to close this once you can get pylint to pass
Passing