NREL/rex

Logger path manipulation

Closed this issue · 4 comments

grantbuster commented

@MRossol should this line use os.path.realpath() instead of normpath? If the handler is ./log_file.log normpath breaks on linux. You already use realpath on line 73 of the same file.

rex/rex/utilities/loggers.py

Line 279 in e747f93

new_handlers = [os.path.normpath(h) for h in new_handlers

MRossol commented

probably, stupid normpath!

MRossol commented

@grantbuster do you need this released?

grantbuster commented

No this is just for a notebook im working on. Easy enough to specify the full filepath but it looked like something we'd want to patch.

MRossol commented

Already patched on main!