NUBIC/surveyor

Add support for Rails 4.2

Jngai opened this issue · 7 comments

Earlier I got a formtastic install error I believe formtastic is surveyor's dependency and this makes the gem incompatible with rails 4.2. Please consider making it compatible with rails 4.2 when you got a chance.

+1 - tried to use it with Rails 4.2 and install failed

yoon commented

For now, try the simple_form branch

I'm using Rails 4.2. With simple_form branch I encounter the error described by archonic here: #480

+1 - I am getting the same "forbidden parameters" error.

It seems the previous lead developer/maintainer is no longer actively involved with this project. If NUBIC is not going to keep this project updated, those of us who need this to work with Rails 4.1+ will need to find a fork.

It is quite a shame though, since it appears to be well-maintained. Most of the test failures on master have to do with environment configuration (like sqlite3 busy errors) and should not be too hard to fix.

yoon commented

Trying to stay involved, but it's on a free time only basis now. Feel free to continue submitting pull requests , I'll do my best to merge them in a timely fashion

FYI, I have just now gotten Surveyor working on Rails 4.2. It likely won't work in Rails 5, but this will buy us some time. Add this to your Gemfile:

# Use the latest functionality which hasn't been released as a new gem version yet
gem 'surveyor', :git => "git://github.com/NUBIC/surveyor.git",
  :ref => "d4fe8df2586ba26126bac3c4b3498e67ba813baf"

# Extends the runway for the current version of Surveyor to work with Rails 4.2
gem 'protected_attributes'

That's it! YMMV - I think we're running pretty close to a stock Surveyor setup, but it's an old project and I wasn't involved in the setup. All I know is my specs and Cucumber features are passing and that's all it took.