UniformBuffer seems to be missing from D3D12 branch

Question

UniformBuffer seems to be missing from D3D12 branch

zigguratvertigo opened this issue 8 years ago · 6 comments

Hi,

Grabbed the latest code via the zip download github feature. UniformBuffers seem to be missing from this branch.

\falcor-d3d12\samples\effects\normalmapfiltering\normalmapfiltering.h(48): error C2653: 'UniformBuffer': is not a class or namespace name
\falcor-d3d12\samples\effects\normalmapfiltering\normalmapfiltering.h(48): error C3646: 'mpLightBuffer': unknown override specifier
\falcor-d3d12\samples\effects\normalmapfiltering\normalmapfiltering.h(48): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

[...]

Similar results when syncing via SourceTree to this specific branch (commit: [ad16784]).

Answer 1 · 2017-03-06T19:01:46.000Z

The file was renamed to ConstantBuffer in the D3D12 dev-branch. We were focusing on adding features and cleaning the interfaces, so some of the samples don't work yet.
I'll fix it later this week.

Thanks!

Answer 2 · 2017-03-07T00:54:26.000Z

NormalMapFiltering sample is fixed

Answer 3 · 2017-03-08T06:54:21.000Z

Unfortunately, issue still exists if you get the latest d3d12 branch.

Answer 4 · 2017-03-08T07:21:26.000Z

The latest NormalMapFiltering.h doesn't have any reference to UniformBuffer.
What error are you getting?

Answer 5 · 2017-03-08T07:25:35.000Z

NormalMapFiltering is indeed fixed. :)

I get it in StereoRendering. Seems to be the last one.

stereorendering.h(50): error C2653: 'UniformBuffer': is not a class or namespace name

Answer 6 · 2017-03-08T07:27:50.000Z

The D3D12 branch was merged into master, where I removed StereoRendering from the solution for now. I'll fix it in a few days.