Compiling on linux breaks due to "-Werror"

Question

Compiling on linux breaks due to "-Werror"

stkrake opened this issue 2 years ago · 10 comments

CMakeLists.txt release v2.12.1 introduced -Werror for non-MSVC compilers. This breaks compilation on linux.
See attached file: Werror_errs.txt. Most of it seems to be in MathLib.h (-Werror=strict-aliasing).

Compiler is gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)

Answer 1 · 2022-02-09T14:28:43.000Z

Thanks! Some of these warnings can be fixed, some are really hard to fix. Let's keep this one open, but I would suggest removing -Werror for now as a suitable WAR.

Answer 2 · 2022-02-09T14:42:12.000Z

I am totally happy without -Werror is this case 😄 Some warnings in MathLib may not even be avoidable...

Answer 3 · 2022-02-09T14:49:17.000Z

At least I will try to minimize the amount of warnings...

Answer 4 · 2022-02-09T14:50:19.000Z

Some warnings (when unreasonable) could instead be disabled (e.g. -Wno-unknown-pragmas)

Answer 5 · 2022-02-09T14:59:45.000Z

Some warnings (when unreasonable) could instead be disabled (e.g. -Wno-unknown-pragmas)

Thanks. That's the plan :)

Answer 6 · 2022-02-09T15:06:10.000Z

On VC++ I usually put things with breaking warnings inside #pragma warning(push) #pragma warning( disable,...) #pragma warning(pop). This limits the "warning-lessness" to known areas. But this may become a compiler compatibility nightmare if extended to gcc and clang.

Answer 7 · 2022-02-09T15:14:18.000Z

Unfortunately, I can't provide ETA. I wanna spend some time on this task, but need to find a remote Linux machine or setup a virtual machine first.

Answer 8 · 2022-02-09T15:59:42.000Z

I can now confirm that it compiles (and works) after simply removing -Werror from CMakeLists.txt.

Answer 9 · 2022-02-11T16:45:16.000Z

@stkrake I believe I fixed the issue. Please, verify.

Answer 10 · 2022-02-11T17:29:50.000Z

Yes, compiles and works out of the box now. On win32 and linux. Without a single warning 😄

Closing this. Many thanks.