Nagasaki45/bibo

Revert temp path completion when resolved upstream

Nagasaki45 opened this issue · 2 comments

We hacked together a temporary path completion in #38 / #61. The issue should hopefully be solved by click itself (follow pallets/click#780 & pallets/click#782). Revert the temporary fix when there's a solution upstream.

Hi @Kappers! Click 8 was just released, with support for path completion. Tested it now and it looks like we don't need to do anything to get automatic path completion. Feel bad for deleting a bunch of your code from the repo, but I guess that's for good. Feel free to test / comment, and thanks for the contribution again. EDIT: The new path completion is in bibo 1.5.0 which is now available from pypi.

@Nagasaki45 Sorry for being slow, I was on holiday! I think it's great that click provides support for this, thanks for reverting this band-aid 😄