NaturalNode/node-sylvester

Use of Global variables in $V, $L, $M, $P node package

jondayft opened this issue · 6 comments

jondayft commented

Is there a reason that $V ,$L, $M, $P are in global scope? This is currently causing issues when testing with mocha, so we are having to add these to the mocha --globals option. Since everything is being exported it would seem like the attachment to global variable isn't required.

I assume there may be a very good reason for this but doesn't seem like best practice?

krazik commented

+1

oveddan commented

+1

connor4312 commented

Also: the global addition of Math.sign

connor4312 commented

Hi all, I recently signed on as a maintainer of this project. I'll slate this for a stable 1.0.0 release 😄

  • 👍1