Option to disable sound patching/Fix for versions using original "minecraft net" url resources
Opened this issue · 2 comments
Hello. I want to start this off by saying i really appreciate you efforts with your fork of RetroWrapper and allowing people like me to play old obscure versions of minecraft once more with ease. seriously thank you, we need more people like you for game preservation :)
I've been using RetroWrapper for the past 3 years in MultiMC and it's been a blast. i apologize ahead of time as there is going to be alot of text.
There is an issue i've always been having. It has to do with missing sounds for all versions prior to a1.1.2_01. this also includes infdev and indev versions. The only sounds that are "cached" and played are what i assume are the "classic" sounds that only contain the resources/sounds/step sound assets. So 80% of all other sounds from directories like "newsound" are never recognized and thus never play in versions that they should. i've personally done multiple weeks worth of tweaking trying different solutions but all have failed. this is for all versions that call the original "www minecraft net" for resources.
i do notice RetroWrapper attemps to download the .json for sound files for certain builds e.g inf-20100607 and a1.0.3 and so on. but these all seem to share the same problem with only the block step sounds being utilized for some reason.
I'm no programmer and i can imagine this issue being pretty difficult to debug or sort through. but i have found a semi-solution that could also be beneficial towards this. I have recently gotten a fiddler setup with the alpha sound resources and it works! in MultiMC i can play down to inf-20100325 with full working audio and no major issues even without RetroWrapper. However any versions lower than that are impossible to run without RetroWrapper and i'd still love to benefit from the fixes and improvements that it has.
I notice that the wrapper changes the www minecraft net resources url to a localhost 127 0 0 1 ip with a random port number on launch every time. in this case it makes it impossible for me to use my proxy debugger to fix the audio as the port changes every-time. So i was wondering if you'd have the time to create a setting or feature to either disable the sound-patching all together or force it to use a specific port on startup. That would be wonderful.
Hi @Grrgamerpro60, thanks for the bug report and appreciation! I'm glad RetroWrapper has been useful for you :) I'll hopefully take a look at the audio soon, I've been fairly busy. I might add a setting to force RetroWrapper to use a specific port in the meantime.
Owner
Thanks for the response! any solutions or tweaks you bring to this is well appreciated :)