NeTEx-CEN/NeTEx

Renaming the subsitution group not to be alike with a class (ServiceAccessRight)

skinkie opened this issue · 2 comments

I would like to have a discussion on things that are either abstracts or subsitution groups currently suffixed with "_". This causes code generation to do funky things. Is there any way we could just rename them to something so it becomes clear they are not to be used as element ever? This is at least the case for ServiceAccessRight.

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_part_3/part3_fares/netex_fareProduct_version.xsd#L145

Suggestion to take a look at:

assignment_version_structure
bounding_box_structure
empty_type
extensions
extensions_structure
group_of_entities_ref_structure
line_shape_structure
location_structure
point
point_on_link_ref_structure
series_constraint_ref_structure
service_access_right
srs_name
travel_specification

Objects with a trailing "" like **ServiceAccessRight** should probably be abstract
A trailing "" also mean that they are not to be used as element ever
But all abstract object don't have a "
", we could have a convention to add it ... I don't think that this would break anything

Discussed: Replace he trailing "_" with "_Dummy" ... to be done at the end of the revision process by @skinkie