Why is ServiceFacilitySet, SiteFacilitySet, PassengerCapacity not a VersionedChild?

Question

Why is ServiceFacilitySet, SiteFacilitySet, PassengerCapacity not a VersionedChild?

skinkie opened this issue 2 years ago · 14 comments

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_framework/netex_reusableComponents/netex_facility_version.xsd#L306

Answer 1 · 2023-01-09T00:40:22.000Z

You want to investigate:
'LineSection', 'ServiceAccessRight2', 'ActivatedEquipment', 'SimpleValidityCondition', 'TravelSpecification2', 'FareSection', 'GroupOfStopPlaces', 'ServiceFacilitySet', 'TimetabledPassingTimeView', 'EstimatedPassingTimeView', 'ComplexFeature', 'GeneralSection', 'SiteFacilitySet', 'OtherPlaceEquipment', 'CommonSection', 'TargetPassingTimeView', 'FareContractEntry', 'ObservedPassingTimeView', 'ServiceAccessRight1', 'SimpleFeature', 'PassengerCapacity'

These are not part of GeneralFrame. My guess is they are invalidly not VersionedChild.

Answer 2 · 2023-01-10T15:04:41.000Z

I think that it makes sense to complement them with a substitutionGroup="VersionedChild"

Answer 3 · 2023-01-10T17:53:36.000Z

@Aurige PassengerCapacity is also a really strange variant. It is an EntityInVersion with an optional id attribute... why make such exceptions?

Answer 4 · 2023-01-11T08:03:57.000Z

I can't see this:

Answer 5 · 2023-01-11T11:27:51.000Z

@Aurige you can here:
https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd#L613

Answer 6 · 2023-01-11T11:38:42.000Z

I have this, but this is not an additional Id, it is the specialisation of the Id to a type="PassengerCapacityIdType" (the original Id being inherited from ENTITY IN VERSION ...)

Answer 7 · 2023-01-11T14:34:46.000Z

Yes, but it now makes an entity in version with an optional id.

Answer 8 · 2023-01-11T15:01:14.000Z

Id is not always necessary when something is mainly embedded in the xml hierarchy, and not a standalone object... but ok, that's not best for database... also in such case there is one single use of the info (no reuse) so you can define the id you want

Answer 9 · 2023-01-11T20:32:29.000Z

I don't think we should promote inconsistent behavior.

Answer 10 · 2023-12-10T03:38:05.000Z

FacilitySets can be reused in many different places.
Just because something can be inlined doesnt make it a versioned child. Typically a versioned child has no independent existance, thus, if its parent is deleted so is it. Similalry the same capacity requirement might be specified on many different vehicle types.

Answer 11 · 2023-12-12T19:15:35.000Z

@skinkie Does Nick's anser satisfy you? Then we might close this issue.

Answer 12 · 2023-12-12T19:20:05.000Z

Not really :-)

Answer 13 · 2023-12-13T15:10:28.000Z

There are some missing substitution groups ... to be fixed

Answer 14 · 2024-04-19T09:49:18.000Z

I do this for 2.1. I guess this is hygiene only.