fareStructureFactor vs fareStructureFactors?

Question

fareStructureFactor vs fareStructureFactors?

skinkie opened this issue a year ago · 9 comments

skinkie commented a year ago

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L139

Answer 1 · 2023-09-07T08:47:52.000Z

fareStructureFactors for sure

Answer 2 · 2023-09-07T08:51:33.000Z

fareStructureFactors for sure

Should it then also be fareStructures?

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/NX.xsd#L254

Answer 3 · 2023-09-07T08:56:59.000Z

Most probably, but only for consistency reasons ... this NX.xsd is just for information (not for use), so provided that you have either XXX either XXXs, the information is there, but consistency is always good !

Answer 4 · 2023-09-07T08:58:55.000Z

If it is actually documentation, it should not be in that folder for my perspective.

Answer 5 · 2023-09-07T12:56:21.000Z

Yes you are fully right

Answer 6 · 2023-12-12T18:03:10.000Z

@skinkie can we close this one?

Answer 7 · 2023-12-12T18:11:12.000Z

@ue71603 if you add 258c905

Answer 8 · 2024-02-02T11:33:19.000Z

@skinkie are those changes already committed? and in which PR? If so, can you close this issue?

Answer 9 · 2024-05-08T10:43:31.000Z

Pls close, if done or add PR.