Nerian/bootstrap-datepicker-rails

pick up <html lang="..."> attribute before defaulting to English

Closed this issue · 4 comments

I would like to suggest the following language precedence order:

  1. language from data-date-language attribute
  2. language from .datepicker() call argument
  3. language from <html lang="..."> attribute
  4. English

If the language determined by this preference list is not loaded/available, then also fall back to English.

For one case of of why/where this would be useful:

https://groups.google.com/forum/#!searchin/hobousers/datepicker/hobousers/0eBz-C9Plr8/sPevKOYust8J

I also posted this upstream: uxsolutions/bootstrap-datepicker#1552

Sounds fine to me. If it gets changed in the upstream repo it will be changed here too.

so are you saying I should leave this open as a reminder, or should I close it?

You can close it now that the discussion is happening in the other repo.