Nesvilab/FragPipe

Browse directly to pasted folder in "Choose raw data files dialog"

Closed this issue · 9 comments

- Describe the feature:
Because the dialog is the old style with the "Look in" dropdown box at the top instead of a breadcrumb textbox, there's no easy way to browse directly to a deep path. The Windows-conventional way to browse directly to a path is to type or paste it in the "File name:" text box and then press enter. Instead of trying to select the file and closing the dialog, it will browse to the folder and let the user select a file from there.

fcyu commented

I am not sure if I follow it. Is that a question or a feature request? But yes, Java's native file system dialog is different from Windows'. There is no place to paste the file path, which also bothers me.

Best,

Fengchao

A video is worth a thousand words: :)
https://github.com/Nesvilab/FragPipe/assets/5011937/7f83f9fb-5afe-4c4d-8eb3-38cce52b278f

There's got to be a way to jury-rig that behavior with Java. In the worst case, if the user selects a folder with the "Choose raw data files" dialog, you can let the native dialog close and then immediately reopen it with the chosen folder selected.

I just realized the Select FASTA dialog DOES work like that. So it must be you're short-circuiting that behavior in the "Choose raw files" dialog (I assume to handle Bruker directories).

Yes but they don't behave the same. When I type a path to a folder in "Choose raw data files" and press Enter, it says:
image

fcyu commented

Wait, I think they are the same

image
image

Best,

Fengchao

fcyu commented

Is your path folder or file? If it is a folder, than has to be .d because that dialog if for LC-MS "files".

The add folder recursively button should bring what you want if you want to put a folder path.

image

Best,

Fengchao

Entering the full path to a file and pressing Enter selects the file and closes the dialog. That's expected and correct. It's entering a folder so I can select some RAW files in it that isn't working. Perhaps only do the "If you are analzying timsTOF" behavior if the folder ends in .d? (I don't want to add the entire folder recursively. I just want to browse to the folder and select some files.)

fcyu commented

That's correct. I think entering a folder to select some RAW files won't work for the current version. Let me take a look if it can be fixed.

Best,

Fengchao

fcyu commented

Hi @chambm ,

Guo Ci @guoci has fixed it in #1653 . Let me know if you want to test the pre-released version or have any questions.

Thanks,

Fengchao