NetSPI/PowerUpSQL

Standardize Cmdlet Verbs

aph3rson opened this issue · 4 comments

aph3rson commented

Per Microsoft's documentation, specific verbs are to be used for Powershell cmdlets, in order to ensure some consistency between third-party modules/official functionality. This is echoed in the warning presented when importing PowerUpSQL:
image

PowerUpSQL uses Create as a verb for these cmdlets:

  • Create-SQLFileXpDll
  • Create-SQLFileCLRDll
  • (internal function) Create-ProcessWithToken

To fix this, these cmdlets/functions should be refactored to use the New verb, which is recommended for use in instances when a new record/object is being created.

aph3rson commented

I'd be happy to submit a PR, if preferred.

nullbind commented

Hey @aph3rson,

Thanks for the request! It would be nice to make things a little cleaner. Let me take a look and see what might be impacted and I will get back to you next week.

Thanks again,

Scott

nullbind commented

I decided to leave the verbs as is. Thanks again for the thought though.

aph3rson commented

I decided to leave the verbs as is. Thanks again for the thought though.

@nullbind if that's the case, could the documentation be updated to call out the expected warning on import?
It's not documented anywhere, so folks using it can get confused and think the install was unsuccessful.