NetSparkleUpdater/NetSparkle

Missing code paths in InstallUpdate method

bdovaz opened this issue · 1 comments

bdovaz commented

I am using the Core package and I am managing all the UI through events and that is why I have detected these cases.

  1. If the file does not exist, there is no event, log, etc. that notifies that the file does not exist and that it cannot proceed:

NetSparkle/src/NetSparkle/SparkleUpdater.cs

Line 1221 in 225fb7b

if (File.Exists(path))

  1. If the result of the signature verification is Invalid a case similar to the previous one happens, there is no else on that condition that notifies of what happens:

NetSparkle/src/NetSparkle/SparkleUpdater.cs

Line 1234 in 225fb7b

if (result == ValidationResult.Valid || result == ValidationResult.Unchecked)

If these 2 cases are not managed it is very difficult to debug what is happening without having to check this repository and its source code.

Deadpikle commented

Thanks! Added InstallUpdateFailed event for those two cases (along with some LogWriter calls) and a couple other cases I noticed. 611eb7c and preview rolling out now.