Netflix/dial-reference

Some DIAL Server js_tests don't expect proper POST response codes for running applications

Opened this issue · 1 comments

The nodejs tests for a DIAL server have multiple issues where incorrect codes are expected in response to a POST request to the Application Resource URL:

  1. https://github.com/Netflix/dial-reference/blob/master/server/tests/js_tests/tests/launchApplicationInRunningStateWithNoPayload.js#L86

  2. https://github.com/Netflix/dial-reference/blob/master/server/tests/js_tests/tests/launchApplicationInRunningStateWithPayload.js#L86
    These tests expect a 201 Created when 6.2.2 of the DIAL 2.2 spec indicates 200 OK should be returned if application state is Running. A 201 Created is only appropriate if the application is not currently running or it is hidden.
    For the launchApplicationInRunningStateWithPayload test, if the current application does not support payloads or fails to process the payload, a 501 Not Implemented is also acceptable (new for DIAL 2.2)

  3. https://github.com/Netflix/dial-reference/blob/master/server/tests/js_tests/tests/hideInvalidApplicationInstance.js#L39
    Similar to the above issues, this test expects a 201 Created response regardless the current state of the application, when 6.2.2 of the DIAL 2.2 spec indicates 200 OK should be returned if application state is Running or Starting and 201 Created should be returned if the application state Stopped . However, this test assumes the application is not currently running and is missing the startAppIfNotRunning() function found in other tests. This assumption can result in intermittent failures of this test.

seoz commented

Any update on this issue?