Netflix/hollow

Condition 'doubleSnapshotConfig.allowDoubleSnapshot()' should be negated

wangsfx opened this issue · 0 comments

if (doubleSnapshotConfig.allowDoubleSnapshot() && failedTransitionTracker.anyTransitionWasFailed(updatePlan)) {

The code is inconsistent with the comments 'If the consumer is configured to only follow deltas (no double snapshot) then any failure to transition will cause the consumer to become "stuck" on stale data', so the condition 'doubleSnapshotConfig.allowDoubleSnapshot()' should be negated