Netflix/ribbon

LoadBalancerContext.noteResponse never called, and LoadBalancerContext.noteRequestCompletion doesn't include the actual request

chairbender opened this issue · 0 comments

https://github.com/Netflix/ribbon/search?q=noteResponse&unscoped_q=noteResponse

This method is implemented and overridable but seems it never actually gets called.

I was hoping to use this so I could log the request URL and actual service instance that a request was sent to. I couldn't find a non-hacky way to do this other than sticking that info into a response header in noteRequestCompletion. LoadBalancerContext.noteRequestCompletion DOES get called (in LoadBalancerCommand, for example), but it doesn't include the ClientHttpRequest in the params so I can't see what URL this response is for.