Remove totalDifficulty from block in json reponse

Question

Remove totalDifficulty from block in json reponse

Closed this issue 2 months ago · 6 comments

smartprogrammer93 commented 3 months ago

based on this merged PR:
ethereum/execution-apis#570

Answer 1 · 2024-09-05T05:14:05.000Z

@smartprogrammer93 Hello! I would like to do this, I come from dojo coding, I would like to contribute to the project!

Answer 2 · 2024-09-05T05:14:14.000Z

Hey @Elianfarias!
Thanks for showing interest.
We've created an application for you to contribute to Nethermind.
Go check it out on OnlyDust!

Answer 3 · 2024-09-05T05:19:39.000Z

@Elianfarias sure go ahead.

Answer 4 · 2024-09-09T12:58:40.000Z

Hi @smartprogrammer93!
I'm doing my first issue of the Nethermind project.
I understand the context, that the scheme underwent a change, the TotalDifficulty property in the Type Block was removed.
I see in the nethermind solution, there is a "Core" project in which the Block and HeaderBlock classes have the totalDifficulty property, should I delete it and fix the errors that the solution throws?
I don't know which section of discord to send this query, could you tell me so I don't bother you in private next time?

Answer 5 · 2024-09-16T06:54:35.000Z

@smartprogrammer93 are we sure this is good idea? We still support AuRa and Clique networks, where total difficulty has meaning. We still support block explorers like blockscout which could use it.

Answer 6 · 2024-09-16T21:50:39.000Z

To be honest I wouldn't merge that PR. Just because Main Ethereum doesn't need it (and spec is about main Ethereum), doesn't mean we should remove it because our clients are using other consensus algorithms and may still need it. Just let it be until proven unnecessary.