NeunEinser/bingo

Lockout mode can be started with all players on the same team

Closed this issue · 3 comments

When lockout mode is active, a game can be started even though all players are on the same team. I would argue this is inconsistent behavior with singleplayer, as all players (there is only one in SP) are on the same team there as well and lockout mode is not accessible. Because of this, I feel like a game with lockout mode active should not be startable when there are not at least two teams containing a non-zero amount of players.

The game internally disables lockout mode in that case and will behave as if it is disabled (and thus won't announce the lockout race winner at the same time as a blackout happens)

Personally, I don't think it needs to be prevented.

We didn't notice until after the game had started that the game randomly put us in the same team when starting the card. A simple note before starting the game could do the trick as well.

There is a bug with the current random team selection, in that only about 50% of the teams are possible (every team that is assigned an uneven integer), except for orange, which is assigned 1, where the chance is 50% of picking that team...

The fix of that bug should make this much rarer (1%) (currently 25% of two players in a row being assigned orange).

Possibly, I might change the random team selection further, so that all teams are first filled with 1 player, in a random order, than with a second player, then with a third, and so on, but not sure this will be necessary.