NeuromatchAcademy/course-content-dl

W2D1 Tutorial 1: Videos do not render on jupyterbook

spirosChv opened this issue · 3 comments

The code produce no error during the book generation process. But, the videos are not shown in the book. See here: https://deeplearning.neuromatch.io/tutorials/W2D1_ConvnetsAndRecurrentNeuralNetworks/student/W2D1_Tutorial1.html

Maybe the issue is related to the magic cell (%%html) usage. See also this #471

When HTML or %%html is used, videos are not rendered.

from IPython.display import HTML
display(HTML('filename.html'))

This code does not allow the videos to render on jupyter-book.

A temporal fix is to add a bool variable that controls if the demo is automatically executed during the workflow. Students can change this to True and play with the Demos.

Fixed in this PR: #573