some crossings inventoried in 2022 still need to be entered into PSCIS
NewGraphEnvironment opened this issue · 3 comments
will need to QA before submission next time as we now have lots of missing reporting and a good deal of extra work that could have been avoided.
looks like they may be ones that were not assigned a PSCIS ID or modelled ID. Seems fairly easy to remedy based on the locations on the Form PSCIS in sern_skeena_2023.
Proposed workflow is to save form_pscis_template.gpkg as another file in sern_skeena_2023 mergin project and do edits in QGIS while keeping a list of the crossings altered here (ex:
PSCIS 8551, 8552, 123750
Modelled 1803951
for now anyway - The new files pscis_reassessments2.xls and pscis_phase1.xls will need to be stashed in a new directory data/revised so they don't show up in the reporting.
Once the data is in the new geopackage we can run the pscis_tidy script and the to get it ready for transfer into new spreadsheets for submission.
We should make new photo directories, move and rename photos using https://github.com/NewGraphEnvironment/fish_passage_moti_2022_reporting/blob/main/scripts/functions.R (see what df_test object is by looking at https://github.com/NewGraphEnvironment/fish_passage_moti_2022_reporting/blob/main/scripts/photo_rename.R . This is noted in https://github.com/NewGraphEnvironment/dff-2022/issues/34
We should always be looking for ways to build/improve functions and clarify where the latest versions of our new tidy scripts and test functions are through issues. If there are loose ends lets try to highlight them before moving on
8551 and 8552 are in skeena 2022 reassessments. Crossing 123570 is in bulkley 2022 reassessments. Is that crossing the same as modelled crossing 1803951? As you can see in the first picture you posted they are beside each other. So either 123570 is on a trib that's not mapped or that one should be matched to 1803951 and inputted into Simons pscis_modelledcrossings_streams_xref.csv file.
crossings layer (see screenshot) shows us that bcfishpass has it tied together to Miller Creek and PSCIS 123570 (without help from the csv) which looks right to me. Tieasha's should be a reassesment of 123570. I don't see the photos anywhere in the repo but guessing the directory is just misnamed (123750 perhaps?). Its a big creek and that looks about right from the photos of 123750 (note the flipped 5 and 7).
In the shared sern_skeena_2023 project - last years form is in the 2022 file named as the 2022_form_pscis_archived_dont_use layer (see screenshot)
Good catch. I renamed the folder and amended the PR.