NginxProxyManager/nginx-proxy-manager

Darkmode border Modal Dialog

Opened this issue · 2 comments

vsc55 commented

Is your feature request related to a problem? Please describe.
This is more of an aesthetic detail than a functional one.
With dark mode active, when opening a dialog box, such as an event in the Audit Log section, the dialog box outline is not clearly defined.

Image

Describe the solution you'd like
Add a lighter color to the edge to create contrast.

Describe alternatives you've considered
Add Styple border-color:

Image

Result:

Image

A border should not be used to fix this, as it's not addressing the problem. The fix should be:

  • Actually darken the backdrop, instead of reducing opacity. Currently the backdrop is the same color as the background of the modal.
  • Backdrop-filter blur (might not even be needed).
  • Use a dark shadow for the modal. Currently the modals have white shadows in darkmode. I've never seen a white shadow in real life, so also don't use it in UI.
Image

This is what it looks like when you darken the backdrop, do a blur and use a dark shadow:

Image
vsc55 commented

Yes, it looks much better.